Fix incorrect image upload error message #11493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-trunk Merge 18.6 code freeze to trunk
# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/FeatureFlag.kt
…flag-m2 [Dynamic dashboard] feature flag for m2
…eader [Dynamic Dashboard] Introduce a component to re-use as header in the filterable cards
Attempt to fix crash on ProductListToolbarHelper
0nko
added
the
feature: product details
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
hichamboushaba
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thanks for taking care of this @0nko, it works well.
Before merging this, it seems to me this is a serious bug, shouldn't we include it in the current beta version?
…nt-empty-pos-activity [Woo Pos] FF, entry point and empty pos activity
Merge 18.6-rc-2 into trunk
0nko
force-pushed
the
fix/image-upload-error
branch
from
f8258be to
900d37e
Compare
|
Thanks @hichamboushaba. I've rebased the branch onto |
Thanks @0nko, there is a failing unit test that's preventing the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the wrong private site status message for self-hosted sites, which prevents the app from uploading images.
To test: